Closed
Conversation
dhx
force-pushed
the
enh/pdf_content_extraction
branch
2 times, most recently
from
f616b07 to
a3ea3a5
Compare
Signed-off-by: dhx <dh.tx.dev@dhx.at>
dhx
force-pushed
the
enh/pdf_content_extraction
branch
from
a3ea3a5 to
69c6d11
Compare
Author
|
Hi @julien-nc I see you've added rtf support, so maybe you can take a look if this implementation for pdf looks good to you or if something is missing? |
julien-nc
requested changes
Feb 3, 2025
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Looks good!
Can you rebase on the main branch?
There's a conflict with composer.lock. Just get rid of yours, rebase on main, install smalot/pdfparser and make a new commit.
Member
|
I made another PR with some adjustments. See #204 |
Author
|
@julien-nc thanks for taking it over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently pdf files can't be used as a text source in the assistant (while they work in context chat).