Better naming of shared output files, support more mime types#218
Merged
Better naming of shared output files, support more mime types#218
Conversation
marcelklehr
reviewed
Apr 10, 2025
marcelklehr
approved these changes
Apr 10, 2025
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/better-naming-shared-result-file
branch
from
e6c3f6b to
d0f8ca2
Compare
marcelklehr
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a task output file is shared from the assistant UI, the file extension is guessed from the mimetype. More types are now supported.
For the download endpoint, setting the mimetype correctly in the response headers is enough for browsers to guess the extension in the suggested file name.