-
Notifications
You must be signed in to change notification settings - Fork 299
Feat: Highlight cards with important labels #7218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a18fdf4
to
d8e5c8f
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
d8e5c8f
to
bbe72b9
Compare
rebased, resolved conflicts 🤕 |
this.$store.dispatch('updateLabelFromCurrentBoard', this.editingLabel) | ||
const payload = { | ||
...this.editingLabel, | ||
customSettings: { ...this.editingLabel.customSettings }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line looks redundant. this.editingLabel
should contain customSettings
already.
this.$store.dispatch('addLabelToCurrentBoard', this.addLabelObj) | ||
const payload = { | ||
...this.addLabelObj, | ||
customSettings: { ...this.addLabelObj.customSettings }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customSettings
was already initialized and assigned to addLabelObj
at line 200. So, line 206 looks redundant.
@marcoambrosini I have tested and it works but we need your advice.
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Koc,
Thanks a lot for your contribution and for taking the time to put this together! 🙏
I’m really sorry, but I’ll have to reject this change for now. Adding an “important” toggle switch for every tag feels a bit redundant since the same effect can be achieved by simply adding another tag. Each new setting adds complexity to the user interface, and we want to be careful not to introduce friction unless the benefit is clear and significant.
Before adding new features or settings, it’s good to ask:
• What value does this bring to the user?
• Could it be done another way without adding extra complexity?
In this case, I don’t think it’s the best tradeoff.
For future contributions, could you please open an issue first so we can discuss ideas before development work starts? That way, we can make sure the effort goes in the right direction.
Thanks again for the initiative and your willingness to improve the project. It’s much appreciated!
Summary
This PR adds "Important" toggle to the Labels. Carts with Labels marked as important are highlighted on a board.
Preview

TODO
Checklist