Skip to content

Conversation

Koc
Copy link

@Koc Koc commented Sep 7, 2025

  • Target version: main

Summary

This PR adds "Important" toggle to the Labels. Carts with Labels marked as important are highlighted on a board.

Preview
image

image

TODO

  • Fix and extend old tests

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Koc Koc force-pushed the feature/add-important-flag branch 7 times, most recently from a18fdf4 to d8e5c8f Compare September 8, 2025 17:19
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/add-important-flag branch from d8e5c8f to bbe72b9 Compare September 13, 2025 21:35
@Koc
Copy link
Author

Koc commented Sep 13, 2025

rebased, resolved conflicts 🤕

this.$store.dispatch('updateLabelFromCurrentBoard', this.editingLabel)
const payload = {
...this.editingLabel,
customSettings: { ...this.editingLabel.customSettings },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks redundant. this.editingLabel should contain customSettings already.

this.$store.dispatch('addLabelToCurrentBoard', this.addLabelObj)
const payload = {
...this.addLabelObj,
customSettings: { ...this.addLabelObj.customSettings },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customSettings was already initialized and assigned to addLabelObj at line 200. So, line 206 looks redundant.

@luka-nextcloud
Copy link
Contributor

@marcoambrosini I have tested and it works but we need your advice.

  • The label edit form doesn't look good
  • Should we show all highlight colors if card has multiple highlight labels? For now, it only shows the color of last highlight label
image

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Koc,

Thanks a lot for your contribution and for taking the time to put this together! 🙏

I’m really sorry, but I’ll have to reject this change for now. Adding an “important” toggle switch for every tag feels a bit redundant since the same effect can be achieved by simply adding another tag. Each new setting adds complexity to the user interface, and we want to be careful not to introduce friction unless the benefit is clear and significant.

Before adding new features or settings, it’s good to ask:
• What value does this bring to the user?
• Could it be done another way without adding extra complexity?

In this case, I don’t think it’s the best tradeoff.

For future contributions, could you please open an issue first so we can discuss ideas before development work starts? That way, we can make sure the effort goes in the right direction.

Thanks again for the initiative and your willingness to improve the project. It’s much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants