Skip to content

fix: avoid invalid false return type #11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: avoid invalid false return type #11231

merged 1 commit into from
Jun 4, 2025

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 4, 2025 •
edited
Loading

iconv and stream_get_contents can return false on error. This adds a fallback handling.

Discovered by Psalm v6.

Extracted from #11224.

@ChristophWurst
fix: avoid invalid false return type
d0f4b55 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst requested a review from st3iny June 4, 2025 06:46
@ChristophWurst ChristophWurst self-assigned this Jun 4, 2025
@ChristophWurst ChristophWurst requested a review from kesselb as a code owner June 4, 2025 06:46
@ChristophWurst
Copy link
Member Author

/backport to stable5.1

@kesselb kesselb merged commit 1c56c41 into main Jun 4, 2025
41 of 43 checks passed
@kesselb kesselb deleted the fix/invalid-false-return-type branch June 4, 2025 09:36
@backportbot backportbot bot mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @kesselb