refactor: mark classes final #11238
Closed
refactor: mark classes final #11238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
commented
Jun 4, 2025
| use OCP\IRequest; | ||
|
|
||
| #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)] | ||
| final #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)] |
|
@kesselb @st3iny what's your take on this? I get the idea of https://psalm.dev/docs/running_psalm/issues/ClassMustBeFinal/, but it seems a bit impractical, at least for classes that we mock often. The only type of class where this seems appropriate are entities (DTOs), the main Application class, and migrations. |
|
Improved performance sounds nice but I'm not really convinced by this idea. For public API it makes sense to mark some classes as final but I'm not sure about the internal stuff. But yeah, we could do this for migrations, DTOs, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99% sure tests will explode without https://packagist.org/packages/dg/bypass-finals
Extracted from #11224