Fix image alignment in email composer #11666
Conversation
CreatorOfBiontium
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Hi, thanks a lot for your PR. We will have a look asap. |
|
Just a claricifation: "CKEditor also ignores image resizing — images are always scaled to the maximum width." => it doesn't display size properly when reopening a draft |
CreatorOfBiontium
force-pushed
the
enh/ckeditor_toolbar
branch
from
8311b9c to
9e66bb7
Compare
This code is from the original PR that I split into two — it contained both dark mode fixes and image alignment, so I had to separate them. It should work, but it still needs a bit more work — especially regarding the signature settings. Signed-off-by: Tobiáš Vašťák <tobias.vastak@gmail.com> Signed-off-by: Biontium <johnsonpe83@gmail.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Biontium <johnsonpe83@gmail.com>
CreatorOfBiontium
force-pushed
the
enh/ckeditor_toolbar
branch
from
d4b6635 to
27445d5
Compare
Fix minor lint issues (extra semicolons, trailing spaces, commas, etc.). Import issues with CKEditor plugins are still pending and will be handled separately. Signed-off-by: Biontium <johnsonpe83@gmail.com>
|
What do you suggest here - the ckeditor doesn't have the plugins for image aligement avalible when running lint. How do we include them? |
|
Thanks for your pr 👍 I think we should evaluate to implement it as ckeditor plugin. I will have a closer look when time allows.
Commit the changes to package.json and package-lock.json. |
Refactored so it works with lint. Signed-off-by: Biontium <johnsonpe83@gmail.com>
|
Adding to package.json not needed – just adjusted imports to satisfy lint and it works :o |
|
Nevermind, it doesn't throw an error in lint, but doesn't work either :( I pushed it there thinking it would import just ok, but I fully tested it just now and it breaks the whole toolbar, as it just doesn't show. Any idea? I might try somethng tomorrow. |
putting it to draft for now |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR focuses on fixing image alignment.
The alignment works when composing and sending emails, but in SignatureSettings.vue it doesn’t display the aligment menu (neither does the button descriptions). That part still needs work.
Additionally: