Skip to content

Accelerate conversion of types #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
claucambra merged 18 commits into from
Dec 23, 2024
Merged

Accelerate conversion of types #32

claucambra merged 18 commits into from
Dec 23, 2024

Conversation

@claucambra
Copy link
Contributor

@claucambra claucambra commented Dec 18, 2024

No description provided.

@claucambra claucambra added this to the 2.0.0 milestone Dec 18, 2024
@claucambra claucambra self-assigned this Dec 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.02564% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (7ffc784) to head (2f1915e).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...dFileProviderKit/Metadata/ItemMetadata+Array.swift 60.86% 18 Missing ⚠️
...tcloudFileProviderKitTests/ChunkedArrayTests.swift 97.18% 2 Missing ⚠️
...FileProviderKit/Extensions/NKFile+Extensions.swift 96.29% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   78.43%   78.58%   +0.15%     
==========================================
  Files          44       46       +2     
  Lines        9945    10030      +85     
==========================================
+ Hits         7800     7882      +82     
- Misses       2145     2148       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claucambra
Simplify conversion of nkfiles to metadatas, remove massive async gro…
f164f0a 
…up creation

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Move nkfile from dir read conversion procedure to NKFile extension
d47dbe1 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Simplify and de-concurrencify conversion of item metadatas to file pr…
a7ea872 
…ovider items

Too many threads

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Add array extension to chunk an array
f4a1e73 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Add array extension method to map over a chunked array
1cf6a30 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Add array extension method to perform concurrent map over chunked array
1e18727 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra force-pushed the bugfix/conversion-accel branch from ae66359 to 1e18727 Compare December 23, 2024 05:16
@claucambra
Make concurrentChunkedMap support nil returning transforms, return fl…
9185cd9 
…at array

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Convert metadatasToFileProviderItems into async method using chunked …
31325f8 
…conversion

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Move metadatasToFileProviderItems into extension method for ItemMetad…
7b50d8e 
…ata array

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Add concurrentChunkedForEach
64206be 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Set default chunk size for chunked methods
f0bcd62 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Defer to default chunk size in item metadata array conversion
496b617 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Perform chunked conversion of directory read nkfiles to metadata
6f4cd8a 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Add a test suite for the chunked array methods
a0b6245 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra changed the title Draft: Accelerate conversion of types Accelerate conversion of types Dec 23, 2024
@claucambra
Use an actor to correctly apply concurrent conversion of directory re…
01d45b2 
…ad nkfiles

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Bring in immutable variables in enumerator when converting metadatas …
5d4ac4b 
…to fp items

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Ensure we get the first item first in directory read avoiding concurr…
8a85c53 
…ency issues

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
Pull in metadatas variable as immutable reference in async task
2f1915e 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra merged commit 0bba3dc into main Dec 23, 2024
3 checks passed
@Rello Rello deleted the bugfix/conversion-accel branch August 15, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@claucambra claucambra

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@claucambra @codecov-commenter