Permission tests for the sharing are fully covered in sharing v1 integration tests #26193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration tests See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added
3. to review
MorrisJobke
requested review from
ChristophWurst,
LukasReschke,
PVince81,
danxuliu,
rullzer and
skjnldsv
ChristophWurst
approved these changes
Mar 18, 2021
PVince81
added
4. to release
Member
|
failure unrelated, force merge or restart build ? |
Member
Author
Unrelated IMHO. |
MorrisJobke
deleted the
techdebt/noid/remove-sharing-duplicate-unit-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav.
I found this while working on #24035. Those were basicall integration tests inside unit test files. There is no need to do that complex setups in unit tests if we already have them in the proper integration tests.