Wrong warning when running HTTP instance #26728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Virlet <github@virlet.org>
Signed-off-by: Guillaume Virlet <github@virlet.org>
Contributor
Author
|
I just updated the js tests to remove the failure. I added one test to ensure the error is not raised when HTTP server return HTTP links. But I commented the existing test as I did not find a way to trick the |
skjnldsv
changed the title
juliusknorr
approved these changes
Jul 13, 2021
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #26726.
I checked the test suite, but I cannot see if it has to be modified (I cannot understand where the window.protocol is retrieved from in tests ;-( )
Let me know if anything needs to be modified.