feat: Port jobs table to snowflakes ids #56628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/snowflake/jobs
branch
2 times, most recently
from
3fc86e6 to
98d2fad
Compare
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
come-nc and
salmart-dev
and removed request for
a team
Altahrim
approved these changes
Nov 25, 2025
come-nc
reviewed
Nov 25, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
The type changes are breaking OCP?
CarlSchwan
force-pushed
the
carl/snowflake/jobs
branch
from
98d2fad to
4bb38c9
Compare
artonge
reviewed
Dec 3, 2025
artonge
approved these changes
Dec 3, 2025
Member
Author
Unfortunately, no way to get around that if we want to keep 32bits support :/ Good news is that looking at https://github.com/search?q=org%253Anextcloud+jobList&type=code this has zero impact has these APIs taking an Id are only used in server |
CarlSchwan
force-pushed
the
carl/snowflake/jobs
branch
3 times, most recently
from
5ff3bda to
f544a59
Compare
artonge
approved these changes
Dec 4, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
True that the impact should be limited as it is not used outside server, and also, any basic case should be ok, as the variable used to call getById would probably come from the return value of getJobs, which would be correctly typed.
CarlSchwan
force-pushed
the
carl/snowflake/jobs
branch
2 times, most recently
from
3347572 to
1b10e8e
Compare
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/snowflake/jobs
branch
from
1b10e8e to
0e686fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)