refactor(entity): Don't type id #57442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some apps overwrite this and this breaks them. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
Open
kyteinsky
approved these changes
Jan 9, 2026
| */ | ||
| abstract class Entity { | ||
| public int|string|null $id = null; | ||
| /** @var int $id */ |
Contributor
There was a problem hiding this comment.
not sure but maybe it makes sense to adjust the the variable doc to /** @var int|string|null $id */ for psalm's indication at other places in the server repo since the other adjustments were made according to that
This was referenced Jan 9, 2026
|
|
||
| if ($this->snowflake === null) { | ||
| $this->snowflake = Server::get(ISnowflakeDecoder::class)->decode($this->id); | ||
| $this->snowflake = Server::get(ISnowflakeDecoder::class)->decode($this->getId()); |
Member
There was a problem hiding this comment.
Should we have an explicit getId() in this entity which has the full return type?
ChristophWurst
approved these changes
Jan 9, 2026
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
It is not just that apps may overwrite it but that they use $ob->id on entities for tables that don't use snowflakes. That creates a "viral" change that all APIs consuming the id need to be adapted or that we have to add checks to make Psalm happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some apps overwrite this and this breaks them.
TODO
Checklist
3. to review, feature component)stable32)