handle link clicks properly

[sowjanyakch]

fix #1789

🚧 TODO

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4297-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

processedMessageText can be mixed text with hyperlinks. So "test http://anysite.com" can't be directly converted to a link but the link has to be extracted and only this should be underlined and clickable.
Otherwise there could be a ActivityNotFoundException if the link is not valid.

[mahibi]

to extract links, code from

talk-android/app/src/main/java/com/nextcloud/talk/chat/data/model/ChatMessage.kt

Line 167 in 7ca68b3

fun isLinkPreview(): Boolean {

will be helpful. This is the code which decides if the *LinkPreviewMessageViewHolder is applied.

[mahibi]

However thinking about that there can be multiple links inside a message this gets more complicated. Then there might have to be more complex logic similar like it's used for the chip mentions:

talk-android/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt

Line 220 in 9d62a6f

fun searchAndReplaceWithMentionSpan(

[mahibi]

removing
app:textAutoLink="all"
works and may be mandatory to fix the bug.

However this will change the behavior of all ChatMessage types and automatic link detection won't work as described in
#3481 (comment)