Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 3, 2024

#184 added some handling for symlinks in recurseDelete() but only for files, not directories.

We don't use recursiveDelete() is many places where this is likely to happen currently, but since isDir() resolves/matches on symbolic links it's possible we would rmdir() (and so against the getRealPath()) rather than unlink() it. This would result in trying to:

  • run rmdir() against a symlink
  • run rmdir() against the same target more than once

We use recusriveDelete() to:

  • reset the downloads directory (unlikely to be a problem here)
  • reset the shipped apps directory (could be a problem here, but probably not very common admittedly)
  • reset the themes example directory (could be a problem here, but no

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@github-actions

This comment was marked as off-topic.

@come-nc
Copy link
Collaborator

come-nc commented Feb 10, 2025

Needs to be adapted to #516 , but I think this is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants