Skip to content

refactor: Add SSL verification handling function#1319

Merged
julien-nc merged 1 commit intomainfrom
sslHandlerFunction
Feb 3, 2026
Merged

refactor: Add SSL verification handling function#1319
julien-nc merged 1 commit intomainfrom
sslHandlerFunction

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Feb 2, 2026

DRY principle applied

  • Extracted shouldDisableSSLVerification() private method
  • Eliminated code duplication between get() and post()
  • Added missing debug mode check in post() method

Performance improvements

  • Replaced in_array() with direct comparisons
  • Single getSystemValue() call per method
  • Removed intermediate $client variable
  • Early return pattern for readability

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf marked this pull request as ready for review February 2, 2026 09:25
@julien-nc julien-nc merged commit b396704 into main Feb 3, 2026
38 checks passed
@julien-nc julien-nc deleted the sslHandlerFunction branch February 3, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants