Draft
Conversation
…discovered keys Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
|
I have this code running in our installation for quite some time and everything is perfectly fine. Are we able to proceed with getting this merged to get this bug resolved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-jwt dropped support for P-521 curve. Parsing a keyset which contains a key using this curve will now fail. We could either wait for php-jwt to do something about that. We could also remove this key from the keyset we receive from the IdP.
This is an attempt to fix #823 by removing any key using a P-521 curve from the discovered keys.
The problem I see here is that maybe we are removing a key that we need to decode a token.