fix: fix appconfig usage #1030
Merged
fix: fix appconfig usage #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
fix-appconfig
branch
from
5c51c41 to
fba2aaa
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
fix-appconfig
branch
from
fba2aaa to
7aa7292
Compare
blizzz
approved these changes
Jan 7, 2026
come-nc
approved these changes
Jan 8, 2026
CarlSchwan
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by #1027
unlike
\OCP\AppFramework\Services\IAppConfig,\OCP\IAppconfgrequires explicitly setting the appid.The fact that both #1022 and #1027 had broken DAV kerberos authentication points to a significant lack of CI coverage.
It's probably worth adapting the files_external smb kerberos sso tests, removing the smb parts.