Fix: tolerate spaces in $NXF_TASK_WORKDIR
#6421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, selecting a workDir with spaces or other special Bash characters in the pathname — like `(`, `)`, etc — would result in `cd $NXF_TASK_WORKDIR` failing. Now `$NXF_TASK_WORKDIR` is correctly quoted in the generated `.output.run` scripts. Signed-off-by: Brooks J Rady <b.j.rady@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, selecting a workDir with spaces or other special Bash characters in the pathname — like
(,), etc — would result incd $NXF_TASK_WORKDIRfailing. Now$NXF_TASK_WORKDIRis correctly quoted in the generated.output.runscripts.I just got into Nextflow yesterday, and this is my first time touching Groovy code, so let me know if you'd like to see this fix implemented in some other way!