Skip to content

Conversation

@gonzaponte
Copy link
Collaborator

Add notebooks to

  • Select Kr data and filter out X-rays
  • Create and store lifetime map
  • Create and store geometry map
  • Make all kind of plots

@jahernando
Copy link
Collaborator

jahernando commented Nov 2, 2017

About XR filtering, there is still some code that can be exported outside the NB as a function, I am referring to the part that fits the energy distribution in z-slices to a gaussian an return the mean, sigma and errors from the fits. This function can be used by other user. Maybe it is premature to incorporate to IC, but I will suggest to add a module here with at least that function.

@jahernando
Copy link
Collaborator

About the NB that estimates the lifetime map. Again here there is too much code in the NB. You should move the computation of the lifetime and its errors in x,y bins to a function, use a default value of number of entries to do a fit. The function should return the results of the fits and in addition the chi2/ndf map. Maybe we want to cut in addition on chi2/ndf to accept the fit.

@jahernando
Copy link
Collaborator

About the geometry map with different pitch NB.
I thinks it is ok to save geometrical maps with different pitch at let the client of the map decide what is the one to use. In will include in addition 10 mm pitch.

Nevertheless, you can do an study what can be the optimal pitch for the data set used, by requiring that the map is smooth in any direction. One possibility, is to take the pitch in which the variation of the correction factor between contiguous x,y bins is smaller than n=2-3 sigmas.
This again can be in a module and not in the NB. This is not so relevant to approve this PR, but you should include in your analyses for the future.

@jahernando
Copy link
Collaborator

About the script and the examples NB commits, they are fine and nice.

Please export the two pieces of code discussed above into a separate module, that can be located in core or analysis fonder to approve the PR.

@gonzaponte
Copy link
Collaborator Author

gonzaponte commented Nov 2, 2017

I am referring to the part that fits the energy distribution in z-slices to a gaussian an return the mean, sigma and errors from the fits

You should move the computation of the lifetime and its errors in x,y bins to a function, use a default value of number of entries to do a fit.

I agree that these pieces of code can be needed by other users but, in my experience, fits require flexibility. One needs to tweak and fine-tune in order to get the best out of it. In particular, I have needed to tweak a few things for different runs, but if we encapsulate it in a function, this will be much harder.

That being said, I think it is sensible to try it for these cases, but I am not still convinced it will be better than having the code there (at the end of the day, it is not a huge amount of code).

I would include in addition 10 mm pitch.

Ok, although 8 mm pitch is already quite large.

requiring that the map is smooth in any direction

Not obvious, because the structures that appear in the map makes it a bit tricky, but I will try.

@jahernando
Copy link
Collaborator

The NBs are great!

Check the labels in plots, for example S1(S2) width vs Z is labeled as S1(S2) energy vs Z.

There are some plots that I will like to include

  • Add in compute lifetime map, examples (i.e 3x3) of the S2 vs Z per (x, y) bins, superimpose the profile and the lifetime fit.

  • Add in compute lifetime and geometry map, the chi2/ndf distribution for the fits of the lifetime in bins, and if possible for the gaussian fit to the energy in x, y bins.

I approve this PR!

@gonzaponte gonzaponte force-pushed the KrSelection branch 2 times, most recently from 7e65042 to c243eb3 Compare November 10, 2017 17:27
@jahernando jahernando self-requested a review November 10, 2017 18:46
Copy link
Collaborator

@jahernando jahernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains NBs with the main step of the Kr analysis: selection, lifetime and geometrical correction estimation. NBs are templates, and a script is provided to generate automatically NBs for given runs. NB examples are included too. I approve this PR.

@gonzaponte gonzaponte force-pushed the KrSelection branch 2 times, most recently from 15b8efd to d37375a Compare November 11, 2017 11:57
This notebook takes a kDST and filters the data to produce
a XR-clean kDST in order to facilitate the Kr analysis.

In presence of external gamma sources, the XR production
is very significative and constitutes a source of
background for Kr data. This NB filters the data to
produce a rather pure dataset on which to perform
the regular analysis.
This notebook takes a clean kDST, measures the lifetime at
different points of the XY plane and stores this map in
a hdf5 file.
This notebook takes a clean kDST and a correction file,
performs the lifetime correction and measures the energy
at different points of the XY plane. The resulting map
is stored in the same correction file.
This notebook takes a kDST file and a correction file,
applies all corrections (including time) and makes all
kind of plots about the data.
It runs all four notebooks sequentially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants