-
Notifications
You must be signed in to change notification settings - Fork 13
Kr selection and maps #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Kr
Are you sure you want to change the base?
Conversation
|
About XR filtering, there is still some code that can be exported outside the NB as a function, I am referring to the part that fits the energy distribution in z-slices to a gaussian an return the mean, sigma and errors from the fits. This function can be used by other user. Maybe it is premature to incorporate to IC, but I will suggest to add a module here with at least that function. |
|
About the NB that estimates the lifetime map. Again here there is too much code in the NB. You should move the computation of the lifetime and its errors in x,y bins to a function, use a default value of number of entries to do a fit. The function should return the results of the fits and in addition the chi2/ndf map. Maybe we want to cut in addition on chi2/ndf to accept the fit. |
|
About the geometry map with different pitch NB. Nevertheless, you can do an study what can be the optimal pitch for the data set used, by requiring that the map is smooth in any direction. One possibility, is to take the pitch in which the variation of the correction factor between contiguous x,y bins is smaller than n=2-3 sigmas. |
|
About the script and the examples NB commits, they are fine and nice. Please export the two pieces of code discussed above into a separate module, that can be located in core or analysis fonder to approve the PR. |
I agree that these pieces of code can be needed by other users but, in my experience, fits require flexibility. One needs to tweak and fine-tune in order to get the best out of it. In particular, I have needed to tweak a few things for different runs, but if we encapsulate it in a function, this will be much harder. That being said, I think it is sensible to try it for these cases, but I am not still convinced it will be better than having the code there (at the end of the day, it is not a huge amount of code).
Ok, although 8 mm pitch is already quite large.
Not obvious, because the structures that appear in the map makes it a bit tricky, but I will try. |
831eeda to
db275b0
Compare
|
The NBs are great! Check the labels in plots, for example S1(S2) width vs Z is labeled as S1(S2) energy vs Z. There are some plots that I will like to include
I approve this PR! |
7e65042 to
c243eb3
Compare
jahernando
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains NBs with the main step of the Kr analysis: selection, lifetime and geometrical correction estimation. NBs are templates, and a script is provided to generate automatically NBs for given runs. NB examples are included too. I approve this PR.
15b8efd to
d37375a
Compare
This notebook takes a kDST and filters the data to produce a XR-clean kDST in order to facilitate the Kr analysis. In presence of external gamma sources, the XR production is very significative and constitutes a source of background for Kr data. This NB filters the data to produce a rather pure dataset on which to perform the regular analysis.
This notebook takes a clean kDST, measures the lifetime at different points of the XY plane and stores this map in a hdf5 file.
This notebook takes a clean kDST and a correction file, performs the lifetime correction and measures the energy at different points of the XY plane. The resulting map is stored in the same correction file.
This notebook takes a kDST file and a correction file, applies all corrections (including time) and makes all kind of plots about the data.
It runs all four notebooks sequentially
d37375a to
d920a12
Compare
Add notebooks to