feat(channels): add Facebook Messenger and Pancake channel integrations#731
Open
nguyennguyenit wants to merge 3 commits intodevfrom
Open
feat(channels): add Facebook Messenger and Pancake channel integrations#731nguyennguyenit wants to merge 3 commits intodevfrom
nguyennguyenit wants to merge 3 commits intodevfrom
Conversation
- Add absolute path exemption for dataDir/skills-store/ (fixes skill
scripts using absolute paths like /app/data/skills-store/ being denied)
- Strip surrounding quotes before prefix matching (LLMs often quote paths)
- Reject path traversal ("..") in exempt fields to prevent escape
- Switch from "any field exempt → skip" to per-field matching: only exempt
if ALL fields that match the deny pattern are individually exempt
- Closes pipe/comment bypass vectors where an exempt path in one argument
would exempt the entire command including non-exempt paths
Includes 27 test cases covering: legitimate access, quoted paths,
path traversal, unicode bypass, pipe/comment bypass, mixed args.
- Implement Facebook channel with Graph API, Messenger handler, comment handler, post fetcher, webhook handler, and formatter - Implement Pancake channel with API client, message handler, media handler, webhook handler, and formatter - Register TypeFacebook and TypePancake channel types in channel manager - Register Facebook and Pancake factories in gateway startup - Add facebook and pancake to valid channel types in HTTP handler - Add frontend support: channel type constants, schemas, and API client updates
Keep whatsapp bridge_url + facebook + pancake entries from feature branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeFacebook,TypePancake) in the channel manager constantsfacebookandpancaketo valid channel types in HTTP API handlerTest Plan
go test ./internal/channels/facebook/...passesgo test ./internal/channels/pancake/...passesgo build ./...compiles successfully