CRUD operations for integrations #177
Conversation
Adds documentation for integrations. Addresses running apps with them.
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive support for managing integrations in Nextmv Cloud, enabling connections between applications and external systems like Databricks. It also includes minor documentation and code consistency improvements across the codebase.
- Introduces a complete CRUD API for integrations via the
Integrationclass with methods for creating, retrieving, updating, and deleting integrations - Adds supporting enums (
IntegrationType,IntegrationProvider) and alist_integrationsfunction for managing integration configurations - Updates documentation to consistently use lowercase "application" and removes trailing periods from deprecation messages
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| nextmv/nextmv/cloud/integration.py | New module implementing the Integration class with CRUD operations and supporting enums for integration management |
| nextmv/nextmv/cloud/init.py | Exports new integration-related classes and functions to the public API |
| docs/nextmv/cloud/integrations.md | Comprehensive documentation for creating, configuring, using, and managing integrations |
| docs/nextmv/cloud/reference/integration.md | API reference documentation for the integration module |
| mkdocs.yml | Adds navigation entries for integration documentation pages |
| nextmv/nextmv/output.py | Removes trailing period from deprecation message for consistency |
| nextmv/nextmv/input.py | Removes trailing period from deprecation message for consistency |
| nextmv/nextmv/local/application.py | Updates capitalization: "Applications" → "applications" in docstring |
| nextmv/nextmv/default_app/README.md | Updates capitalization: "Application" → "application" in title |
| docs/nextmv/local/*.md | Updates capitalization: "Application" → "application" for consistency across local documentation |
| docs/nextmv/cloud/*.md | Updates capitalization: "Application" → "application" and "Instances" → "instances" for consistency across cloud documentation |
| docs/nextmv/cloud/index.md | Adds new "Account management" section with integrations feature and updates all application references to lowercase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cowanwalls
left a comment
cowanwalls
left a comment
There was a problem hiding this comment.
A few things caught by Copilot should be looked into or updated. There was another potential error case not caught by Copilot that should also be addressed. Tests would be nice but are not strictly necessary to get this in.
merschformann
left a comment
merschformann
left a comment
There was a problem hiding this comment.
I have a question about how we do updates, but otherwise all fine. And I don't need to be blocking about it.
Thanks for the work! 🤗
Simplifies update logic. Permits dict for configs/secrets. Fixes ENG-6940
Description
Adds support for creating, reading, updating and deleting integrations. Provides docs as well.