Skip to content

Conversation

@victorlin
Copy link
Member

@victorlin victorlin commented Mar 10, 2025

Description of proposed changes

This has more flexibility than ambiguous dates in reduced precision which are limited to the range of a single calendar year or month.

Related issue(s)

Checklist

@victorlin victorlin self-assigned this Mar 10, 2025
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.26%. Comparing base (c2c8a51) to head (4193f87).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
augur/dates/__init__.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1770   +/-   ##
=======================================
  Coverage   74.25%   74.26%           
=======================================
  Files          82       82           
  Lines        9052     9061    +9     
  Branches     1847     1849    +2     
=======================================
+ Hits         6722     6729    +7     
- Misses       2024     2025    +1     
- Partials      306      307    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victorlin victorlin force-pushed the victorlin/support-iso-time-intervals branch 2 times, most recently from 9aa117f to c8b8005 Compare March 11, 2025 22:59
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. My only suggestion is to clearly document the supported formats for date intervals since that will dictate the outputs for augur curate format-dates in #1494

@victorlin
Copy link
Member Author

Note: this format is unsupported during subsampling for the same reason as #844: subsampling doesn't use get_numerical_date_from_value, but instead has its own date parsing logic where only YYYY-MM-DD is supported. I'll look into swapping that with get_numerical_date_from_value.

@victorlin victorlin marked this pull request as draft March 18, 2025 23:11
@victorlin
Copy link
Member Author

#1774 should be resolved before this is merged, so that the new format is supported by subsampling in augur filter.

@victorlin victorlin force-pushed the victorlin/support-iso-time-intervals branch from ed382a0 to a27e55d Compare March 25, 2025 23:35
@victorlin victorlin changed the base branch from master to victorlin/date-parsing-improvements March 25, 2025 23:35
@victorlin victorlin changed the title Support ISO time intervals Support precise date ranges Mar 25, 2025
@victorlin victorlin force-pushed the victorlin/support-iso-time-intervals branch from a27e55d to ca464ab Compare March 25, 2025 23:39
@victorlin victorlin marked this pull request as ready for review March 31, 2025 17:46
@victorlin victorlin force-pushed the victorlin/date-parsing-improvements branch from c0d3f3e to 64c13a6 Compare April 10, 2025 22:43
Base automatically changed from victorlin/date-parsing-improvements to master April 10, 2025 22:58
@victorlin victorlin force-pushed the victorlin/support-iso-time-intervals branch from ca464ab to 18422e7 Compare June 11, 2025 00:26
@victorlin
Copy link
Member Author

As mentioned in #1304 (comment), this should be merged and released alongside #1828 which needs some more work.

@jameshadfield
Copy link
Member

For what it's worth, I don't think we need to wait until #1828 is ready to merge this -- that's been sitting in review for 6 months and I'm guessing will be there for at least a few more. While the linked comment is correct that no existing pipelines would (currently) benefit from this, were it to be released then users could add manual bounds if they so desired.

This has more flexibility than ambiguous dates in reduced precision
which are limited to the range of a single calendar year or month.
@victorlin victorlin force-pushed the victorlin/support-iso-time-intervals branch from 18422e7 to 4193f87 Compare December 9, 2025 18:43
@victorlin victorlin merged commit d15c2e0 into master Dec 9, 2025
85 of 86 checks passed
@victorlin victorlin deleted the victorlin/support-iso-time-intervals branch December 9, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow precise date ranges

5 participants