-
Notifications
You must be signed in to change notification settings - Fork 135
Support precise date ranges #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
=======================================
Coverage 74.25% 74.26%
=======================================
Files 82 82
Lines 9052 9061 +9
Branches 1847 1849 +2
=======================================
+ Hits 6722 6729 +7
- Misses 2024 2025 +1
- Partials 306 307 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9aa117f to
c8b8005
Compare
joverlee521
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. My only suggestion is to clearly document the supported formats for date intervals since that will dictate the outputs for augur curate format-dates in #1494
|
Note: this format is unsupported during subsampling for the same reason as #844: subsampling doesn't use |
|
#1774 should be resolved before this is merged, so that the new format is supported by subsampling in |
ed382a0 to
a27e55d
Compare
a27e55d to
ca464ab
Compare
c0d3f3e to
64c13a6
Compare
ca464ab to
18422e7
Compare
|
As mentioned in #1304 (comment), this should be merged and released alongside #1828 which needs some more work. |
|
For what it's worth, I don't think we need to wait until #1828 is ready to merge this -- that's been sitting in review for 6 months and I'm guessing will be there for at least a few more. While the linked comment is correct that no existing pipelines would (currently) benefit from this, were it to be released then users could add manual bounds if they so desired. |
This has more flexibility than ambiguous dates in reduced precision which are limited to the range of a single calendar year or month.
18422e7 to
4193f87
Compare
Description of proposed changes
This has more flexibility than ambiguous dates in reduced precision which are limited to the range of a single calendar year or month.
Related issue(s)
Checklist