splash: Use anchor element for links #2009
Merged
+6
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces div styled to look like links with anchor elements so that behavior such as opening links in a new tab work as expected. Although the default `SplashContent` component no longer uses the `dispatch` and `changePage` props, I'm keeping them in the parent `Splash` component to prevent breaking changes in the customizable splash component API. Resolves <#2008>
nextstrain-bot
temporarily deployed
to
auspice-splash-links-gvhlsstzm
genehack
approved these changes
Sep 9, 2025
jameshadfield
approved these changes
Sep 9, 2025
victorlin
approved these changes
Sep 9, 2025
| <li key={requestPath}> | ||
| <div | ||
| style={{color: "#5097BA", textDecoration: "none", cursor: "pointer", fontWeight: "400", fontSize: "94%"}} | ||
| onClick={() => dispatch(changePage({path: requestPath, push: true}))} |
Member
There was a problem hiding this comment.
Note from a similar PR nextstrain/nextstrain.org#773 (comment):
The behaviour will be a little different -- dispatching stays within the SPA, whereas links will go to a new URL, fetch the auspice HTML entrypoint, fetch the auspice JS (cache hit), reparse the JS and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Replaces div styled to look like links with anchor elements so that behavior such as opening links in a new tab work as expected.
Although the default
SplashContentcomponent no longer uses thedispatchandchangePageprops, I'm keeping them in the parentSplashcomponent to prevent breaking changes in the customizable splash component API.Resolves #2008
Checklist