Skip to content

Support URLs for non-string value traits #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joverlee521 merged 3 commits into from
Nov 4, 2025
Merged

Support URLs for non-string value traits #2024

joverlee521 merged 3 commits into from
Nov 4, 2025
+10 −6

Conversation

@joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Nov 4, 2025 •
edited by jameshadfield
Loading

Description of proposed changes

Resolves #2023

Checklist

@joverlee521
download/metadata: export URL for non-string values
1912ddd 
Always export URL if it's available for the trait regardless
of the type of the value.

Part of #2023
@joverlee521
infoPanel: display Link for non-string values
e919b93 
Always return the Link component for a trait if it has a URL
regardless of the type of the value.

Part of #2023
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-export-url-p7a8gr43qnh November 4, 2025 21:30 Inactive
jameshadfield
jameshadfield approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good from reading. Happy to merge as long as you've tested some real JSONs?

@joverlee521 joverlee521 temporarily deployed to auspice-export-url-p7a8gr43qnh November 4, 2025 22:08 Inactive
@joverlee521
Copy link
Contributor Author

joverlee521 commented Nov 4, 2025

Happy to merge as long as you've tested some real JSONs?

Yup, I tested locally with the JSON from nextstrain/augur#1926

npm run dev -- --datasetDir ../augur/tests/functional/export_v2/data/

Confirmed the tip info modal displays a clickable link for the numeric value and the downloaded metadata includes a __url column for the numeric field.

@joverlee521 joverlee521 merged commit 6370cc5 into master Nov 4, 2025
16 checks passed
@joverlee521 joverlee521 deleted the export-url branch November 4, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameshadfield jameshadfield jameshadfield approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URLs for non-string values

4 participants

@joverlee521 @jameshadfield @nextstrain-bot