Skip to content

Conversation

@j23414
Copy link
Contributor

@j23414 j23414 commented May 8, 2024

Description of proposed changes

This is a fixup to an earlier commit:

8cd6a13

This updates the docs to reflect that the script will NOT just throw a warning, but actually error out if the gene is not found in the GenBank file. This was flagged by comment:

nextstrain/dengue#47 (comment)

Related issue(s)

Checklist

  • Checks pass
  • This does not cause any behavioral change in the script, since this is editing the comments.

This is a fixup to an earlier commit:

8cd6a13

This updates the docs to reflect that the script will NOT just throw a warning, but actually error out
if the gene is not found in the GenBank file. This was flagged by comment:

nextstrain/dengue#47 (comment)
@j23414 j23414 requested a review from a team May 8, 2024 22:30
@j23414 j23414 requested a review from genehack May 16, 2024 18:12
@j23414
Copy link
Contributor Author

j23414 commented Jun 5, 2024

Any blockers here?

@j23414 j23414 merged commit afff3d9 into master Jun 5, 2024
@j23414 j23414 deleted the fix-newreference-docs branch June 5, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants