Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handedness of the NeXus coordinate system implies that chopper rotation should be positive when rotating clockwise facing away from the source, but the documentation states it is the exact opposite.
This cannot be corrected easily historically, as many systems should have this in place, but it is not correct to describe NeXus as using a right-handed coordinate system with this discrepancy. It also leads to an unintuitive and ugly exception when describing an instrument.
This PR proposes a fix by including a new field,
handedness, that defaults toLeftunless otherwise specified, thus not breaking any existing setups or data files, but allows for another value,Right, which agrees with the standard NeXus coordinate basis and which arises naturally when defining a RHS with a z-axis that runs in a positive direction from source to sample.