fix(title): improve line-height for 5xl/6xl sizes and fix storybook base path#15
Merged
bob-obringer merged 1 commit intomainfrom Jan 19, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bob-obringer
force-pushed
the
fix/title-line-height-storybook-base-path
branch
from
4636e43 to
ea051df
Compare
bob-obringer
force-pushed
the
fix/title-line-height-storybook-base-path
branch
from
ea051df to
6f46944
Compare
…ase path Title: - Changed leading-none to leading-[1.1] for 5xl and 6xl title sizes to prevent text overlap on multi-line headings - Added LargeMultiLine story demonstrating the fix Storybook: - Made base path configurable via STORYBOOK_BASE_PATH env var (defaults to "/" for local dev, "/ui/" for production builds) - Removed hardcoded <base href="/ui/"> from manager-head.html and preview-head.html, now injected conditionally via main.ts Purple Dawn Theme: - Fixed dark mode --primary color - was nearly gray (chroma 0.02), now vibrant purple (oklch(0.65 0.18 290)) ResizableHandle: - Added focus-visible:bg-primary for focus state - Added data-[resize-handle-state=active]:bg-primary for active state - Added focus-visible:ring-offset-background for proper ring offset color - Updated withHandle grip to show purple on focus/active states Added: - /quick-fixes Claude Code skill for streamlined bug fix workflow Bumped version to 1.1.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bob-obringer
force-pushed
the
fix/title-line-height-storybook-base-path
branch
from
6f46944 to
ea5d9e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leading-nonetoleading-[1.1]for 5xl and 6xl title sizes to prevent text overlap on multi-line headingsSTORYBOOK_BASE_PATHenv var (local dev uses/, production builds use/ui/)LargeMultiLinestory demonstrating the line-height fixChanges
src/lib/variants.ts- Updated titleVariants 5xl/6xl line-height.storybook/main.ts- Added dynamic base path configuration.storybook/manager-head.html- Removed hardcoded base tag.storybook/preview-head.html- Removed hardcoded base tagpackage.json- Updated build-storybook script, bumped to 1.1.0title.stories.tsx- Added LargeMultiLine storyCHANGELOG.md- Documented changesTest plan
Screenshots
Large titles with proper line spacing:
🤖 Generated with Claude Code