-
Notifications
You must be signed in to change notification settings - Fork 33
Release 3.2.0 #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonasscheid
wants to merge
130
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 3.2.0 #447
Changes from all commits
Commits
Show all changes
130 commits
Select commit
Hold shift + click to select a range
7fbf8a4
Template update for nf-core/tools version 3.5.1
nf-core-bot 5d55120
merge template
jonasscheid cb2ca7b
bump version to 3.2.0dev
jonasscheid cb7bbb6
topic channel migration local modules
jonasscheid ee4f371
Initial plan
Copilot 1caec35
Change all Channel. to channel. in Nextflow scripts
Copilot b889a26
Merge pull request #430 from nf-core/copilot/sub-pr-429
jonasscheid 38b8881
Remove duplicate entry for .nf-test in .prettierignore
jonasscheid 3ceb970
migrate nf-core modules,subworkflows to topic channels
jonasscheid 57c3e08
Add changelog entry for version 3.2.0
jonasscheid 9d75957
Initial plan
Copilot e991182
Update pipeline version from v3.1.0 to v3.2.0dev in all snapshot files
Copilot 3ff11ef
Merge pull request #432 from nf-core/copilot/sub-pr-429
jonasscheid 5702f5e
Initial plan
Copilot ecd9f94
Remove all cache buster comments from local modules
Copilot 9b7245a
Merge pull request #433 from nf-core/copilot/sub-pr-431
jonasscheid f859ec4
update snapshots with correct versions
jonasscheid 359a447
Merge pull request #429 from nf-core/merge-template-351
jonasscheid 1686d9b
Fix #428: add sequence checking via pyopenms
nborodin30 d481efd
[automated] Fix code linting
nf-core-bot d4e2a6e
Update CHANGELOG
jonasscheid adacf77
Support quant of single runs
jonasscheid ff7cc03
Merge branch 'dev' of https://github.com/jonasscheid/mhcquant into dev
jonasscheid f6a08ac
Add tests
jonasscheid 8f39b60
Update CHANGELOG
jonasscheid 73dd91a
[automated] Fix code linting
nf-core-bot 8e5943a
[automated] Fix code linting
nf-core-bot af99b43
Merge pull request #436 from nborodin30/fix/issue-428
jonasscheid 7e304da
Merge branch 'dev' into dev
jonasscheid f562a09
prevent publishing fileconvert output in single quant runs
jonasscheid 8dbec46
Merge branch 'dev' of https://github.com/jonasscheid/mhcquant into dev
jonasscheid ddbbed5
Apply suggestion from @jonasscheid
jonasscheid 5fcace6
Merge pull request #438 from jonasscheid/dev
jonasscheid 6f93d36
Update openms and openmsthirdparty nf-core modules
jonasscheid 8f939b7
Update local modules to use topic channels for versions
jonasscheid 6ea4f5f
Merge branch 'dev' into topics
jonasscheid d0b1b82
Remove redundant version parsing and channel creation from subworkflows
jonasscheid 81d9698
sync nf-core modules and bump openms version
jonasscheid 8867477
merge origin
jonasscheid 6defe0a
port back nf-core to local: idmassaccuracy since module has been depr…
jonasscheid a8ed2fa
update nf-core modules (with version topics)
jonasscheid 20e9a0b
rm idmassaccuracy from modules.json
jonasscheid 04e7c58
Apply suggestions from code review
jonasscheid bd3903e
fix typo
jonasscheid 87ecb8b
fix precommit
jonasscheid 9e27576
Fix escaped backslash in idmassaccuracy version extraction
jonasscheid eb4b251
Add OPENMS_IDMASSACCURACY to test snapshots
jonasscheid 859ae64
Update test_single_quant snapshot to 3.5.0 versions
jonasscheid 6e8bd6e
Apply suggestion from @jonasscheid
jonasscheid 3b35783
Fix OpenMS tool formatting to use multi-line style
jonasscheid 91bb0f6
Update CHANGELOG.md
jonasscheid ae96114
Update subworkflows/local/rescore/main.nf
jonasscheid 8ba585a
Update subworkflows/local/rescore/main.nf
jonasscheid 98fd653
Update modules/local/openms/featurefinderidentification/main.nf
jonasscheid 17e6397
Update subworkflows/local/rescore/main.nf
jonasscheid c767225
Update subworkflows/local/prepare_spectra/main.nf
jonasscheid d7a9324
Apply suggestion from @jonasscheid
jonasscheid 49c0b78
Merge branch 'nf-core:dev' into dev
jonasscheid c6c4269
Merge branch 'dev' of https://github.com/jonasscheid/mhcquant into dev
jonasscheid eda222d
Merge remote-tracking branch 'upstream/topics' into search-params-sam…
jonasscheid ff79328
Add per-sample search parameter support via samplesheet and presets
jonasscheid 100aa29
Use meta-based search parameters in module configs
jonasscheid c823c07
Group global FDR by search preset instead of merging all samples
jonasscheid 146f77b
Add test profile and samplesheet for search params feature
jonasscheid 15fb6ac
Fix deprecated Nextflow syntax for strict mode compliance
jonasscheid 22e930d
Update CHANGELOG for per-sample search parameters feature
jonasscheid 52d609f
Remove redundant emit declarations from version outputs and clean up …
jonasscheid 2efdd68
Add nf-test for search params and use test-datasets samplesheet
jonasscheid e502ff5
Rename test_search_params to test_search_presets and add nf-test prof…
jonasscheid 83dba10
Merge pull request #431 from nf-core/topics
jonasscheid 570bc7f
Merge remote-tracking branch 'upstream/dev' into search-params-sample…
jonasscheid bab72f6
Remove redundant emit declarations from version outputs and clean up …
jonasscheid 52b1591
Fix CI failures: prettier formatting, lint ignore, and ionannotator s…
jonasscheid d6ad64e
Add search_presets as hidden param in nextflow_schema.json to fix lint
jonasscheid 06184be
Document per-sample search parameters and fix stale ch_versions refer…
jonasscheid 11c1926
Align search preset fragment_mass_tolerance with recommended settings
jonasscheid 7985ec6
Remove duplicate comment in mhcquant workflow
jonasscheid 103bcf5
Propagate search params through pipeline with CLI > samplesheet > pre…
jonasscheid 87179c8
Update docs/usage.md with CLI > samplesheet > preset > default priority
jonasscheid bbf7eb1
Fix lint: move search_param_defaults into resolveSearchParams and ski…
jonasscheid 7a174c4
Fix CLI override detection and add fixed/variable mods as per-sample …
jonasscheid 793e24e
Use workflow.commandLine for CLI override detection instead of hardco…
jonasscheid 9f8ac95
Update snapshots and fix invalid input parameter warning for search_p…
jonasscheid b8a882b
Fix ion annotator join key mismatch and rename XL preset comment
jonasscheid 83a1fd5
Address PR review: fix mods tokenization, revert fixed_mods default, …
jonasscheid 3217313
Add search_presets back to defaultIgnoreParams to fix nf-schema valid…
jonasscheid 01c2f5a
Add TSV validation to search_presets schema, fix PrecursorMassToleran…
jonasscheid 92f3f4b
Add search_presets.tsv, remove old search_presets.config, simplify in…
jonasscheid 2ae3aa6
Update search_presets test for qe/lumos groups with stable snapshot
jonasscheid 8669e50
Add PrecursorErrorUnit to presets, fix fragment_mass_tolerance to 0.0…
jonasscheid 7ca466e
Add ion mobility export and MultiQC distribution plot (#440)
jonasscheid b813fc4
Capture full peptidoform content in search_presets snapshot
jonasscheid 412153f
Add changelog entry for ion mobility export (#441)
jonasscheid 5d5a595
Address PR review comments: remove defaultIgnoreParams hack, simplify…
jonasscheid b28f356
Apply suggestion from @jonasscheid
jonasscheid a5a892f
Merge pull request #441 from nf-core/ion-mobility-export
jonasscheid 337b1da
Merge branch 'dev' into search-params-samplesheet
jonasscheid 951739d
Merge pull request #439 from jonasscheid/search-params-samplesheet
jonasscheid 32beba3
Update Easypqp container version to 0.1.57
jonasscheid d4fbfb3
Update easypqp version to 0.1.57 in environment.yml
jonasscheid 58097c9
Update easypqp version to 0.1.57 in environment.yml
jonasscheid a279912
Update Easypqp container version to 0.1.57
jonasscheid d901f85
Update dependencies in CHANGELOG.md
jonasscheid 77306da
Update container version in main.nf
jonasscheid 3fda647
Update container version in main.nf
jonasscheid 8a83694
Update easypqp version to 0.1.57 in tests
jonasscheid 29dc6f1
Merge pull request #442 from nf-core/bump-easypqp.version
jonasscheid f079010
Fix global FDR null:null precursor length by propagating search param…
jonasscheid 51d63aa
Propagate search params in global FDR meta for speclib subworkflow
jonasscheid 41694ce
Group speclib global FDR by search_preset, not hardcoded 'global'
jonasscheid 517751d
Remove meta propagation in speclib global grouping to not break group…
jonasscheid dd9a7fd
Merge pull request #443 from jonasscheid/fix/global-fdr-meta
jonasscheid e80ba60
Add SDRF/PRIDE input support via --input parameter (#277)
jonasscheid 4d9db6d
Fix SUMMARIZE_RESULTS crash with --quantify due to OpenMS 3.5.0 TextE…
jonasscheid 4c893c1
Update CHANGELOG for #444
jonasscheid b046949
Merge pull request #444 from jonasscheid/fix/summarize-result-quant
jonasscheid 8f9f5e0
Restructure SDRF/PRIDE local modules under sdrf_pipelines/ and pridep…
jonasscheid 2cc240e
Move pridepy download protocol flag to ext.args and use join for samp…
jonasscheid 7acbdcf
Update test snapshots with stripped percolator version
jonasscheid 664b006
Add SDRF input test profile and nf-test
jonasscheid b29d28d
Align test_sdrf.config resource limits with other test configs
jonasscheid 60ac195
Use 500-protein fasta subset and spectrum_batch_size=20000 in test_sdrf
jonasscheid 36c5ea8
Move PRIDEPY retry settings to base.config and document SDRF/PRIDE in…
jonasscheid 2b75fdb
fix: broadcast fasta channel to EPICORE so it runs per sample
axelwalter 18c9e6a
docs: fill in PR number in CHANGELOG entry
axelwalter 5cd351a
Merge pull request #446 from nf-core/fix/epicore-single-sample
jonasscheid 249a1df
Update SDRF snapshot for single-row test data and reformat usage table
jonasscheid 1488e0f
Merge pull request #445 from jonasscheid/feature/sdrf-pride-input
jonasscheid de98bd5
Pin tdf2mzml container to 0.4_noentry and use tdf2mzml CLI with dynam…
jonasscheid d454666
Merge pull request #448 from jonasscheid/fix/pin-tdf2mzml
jonasscheid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,5 @@ testing/ | |
| testing* | ||
| *.pyc | ||
| null/ | ||
| CLAUDE.md | ||
| .claude/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,4 +12,5 @@ testing* | |
| bin/ | ||
| .nf-test/ | ||
| ro-crate-metadata.json | ||
| .nf-test/ | ||
| modules/nf-core/ | ||
| subworkflows/nf-core/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://raw.githubusercontent.com/nf-core/mhcquant/master/assets/schema_search_presets.json", | ||
| "title": "nf-core/mhcquant pipeline - params.search_presets schema", | ||
| "description": "Schema for the search parameter presets file provided with params.search_presets", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "PresetName": { | ||
| "type": "string", | ||
| "pattern": "^[a-zA-Z0-9_]+$", | ||
| "errorMessage": "PresetName must contain only alphanumeric characters and underscores", | ||
| "meta": ["preset_name"] | ||
| }, | ||
| "PeptideMinLength": { | ||
| "type": "integer", | ||
| "minimum": 1, | ||
| "errorMessage": "PeptideMinLength must be a positive integer", | ||
| "meta": ["peptide_min_length"] | ||
| }, | ||
| "PeptideMaxLength": { | ||
| "type": "integer", | ||
| "minimum": 1, | ||
| "errorMessage": "PeptideMaxLength must be a positive integer", | ||
| "meta": ["peptide_max_length"] | ||
| }, | ||
| "PrecursorMassRange": { | ||
| "type": "string", | ||
| "pattern": "^\\d+:\\d+$", | ||
| "errorMessage": "PrecursorMassRange must be in format 'min:max' (e.g., '800:2500')", | ||
| "meta": ["digest_mass_range"] | ||
| }, | ||
| "PrecursorCharge": { | ||
| "type": "string", | ||
| "pattern": "^\\d+:\\d+$", | ||
| "errorMessage": "PrecursorCharge must be in format 'min:max' (e.g., '2:3')", | ||
| "meta": ["prec_charge"] | ||
| }, | ||
| "PrecursorMassTolerance": { | ||
| "type": "number", | ||
| "minimum": 0, | ||
| "errorMessage": "PrecursorMassTolerance must be a non-negative number", | ||
| "meta": ["precursor_mass_tolerance"] | ||
| }, | ||
| "PrecursorErrorUnit": { | ||
| "type": "string", | ||
| "enum": ["ppm", "Da"], | ||
| "errorMessage": "PrecursorErrorUnit must be either 'ppm' or 'Da'", | ||
| "meta": ["precursor_error_units"] | ||
| }, | ||
| "FragmentMassTolerance": { | ||
| "type": "number", | ||
| "minimum": 0, | ||
| "errorMessage": "FragmentMassTolerance must be a non-negative number", | ||
| "meta": ["fragment_mass_tolerance"] | ||
| }, | ||
| "FragmentBinOffset": { | ||
| "type": "number", | ||
| "minimum": 0, | ||
| "errorMessage": "FragmentBinOffset must be a non-negative number", | ||
| "meta": ["fragment_bin_offset"] | ||
| }, | ||
| "MS2PIPModel": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "Immuno-HCD", | ||
| "timsTOF", | ||
| "CIDch2", | ||
| "HCD", | ||
| "CID", | ||
| "ITMS", | ||
| "iTRAQ", | ||
| "iTRAQphospho", | ||
| "TMT", | ||
| "HCDch2" | ||
| ], | ||
| "errorMessage": "MS2PIPModel must be a valid MS2PIP model name", | ||
| "meta": ["ms2pip_model"] | ||
| }, | ||
| "ActivationMethod": { | ||
| "type": "string", | ||
| "enum": ["ALL", "CID", "HCD", "ETD", "ECD", "EThcD", "ETciD"], | ||
| "errorMessage": "ActivationMethod must be one of: ALL, CID, HCD, ETD, ECD, EThcD, ETciD", | ||
| "meta": ["activation_method"] | ||
| }, | ||
| "Instrument": { | ||
| "type": "string", | ||
| "enum": ["high_res", "low_res"], | ||
| "errorMessage": "Instrument must be either 'high_res' or 'low_res'", | ||
| "meta": ["instrument"] | ||
| }, | ||
| "NumberMods": { | ||
| "type": "integer", | ||
| "minimum": 0, | ||
| "errorMessage": "NumberMods must be a non-negative integer", | ||
| "meta": ["number_mods"] | ||
| }, | ||
| "FixedMods": { | ||
| "type": "string", | ||
| "errorMessage": "FixedMods must be a comma-separated list of UNIMOD modification names", | ||
| "meta": ["fixed_mods"] | ||
| }, | ||
| "VariableMods": { | ||
| "type": "string", | ||
| "errorMessage": "VariableMods must be a comma-separated list of UNIMOD modification names", | ||
| "meta": ["variable_mods"] | ||
| } | ||
| }, | ||
| "required": [ | ||
| "PresetName", | ||
| "PeptideMinLength", | ||
| "PeptideMaxLength", | ||
| "PrecursorMassRange", | ||
| "PrecursorCharge", | ||
| "PrecursorMassTolerance", | ||
| "FragmentMassTolerance", | ||
| "FragmentBinOffset", | ||
| "MS2PIPModel", | ||
| "ActivationMethod", | ||
| "Instrument", | ||
| "NumberMods" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| PresetName PeptideMinLength PeptideMaxLength PrecursorMassRange PrecursorCharge PrecursorMassTolerance PrecursorErrorUnit FragmentMassTolerance FragmentBinOffset MS2PIPModel ActivationMethod Instrument NumberMods FixedMods VariableMods | ||
| lumos_class1 8 14 800:2500 2:3 5 ppm 0.01 0.0 Immuno-HCD HCD high_res 3 Oxidation (M) | ||
| lumos_class2 8 30 800:5000 2:5 5 ppm 0.01 0.0 Immuno-HCD HCD high_res 5 Oxidation (M) | ||
| qe_class1 8 14 800:2500 2:3 5 ppm 0.01 0.0 Immuno-HCD HCD high_res 3 Oxidation (M) | ||
| qe_class2 8 30 800:5000 2:5 5 ppm 0.01 0.0 Immuno-HCD HCD high_res 5 Oxidation (M) | ||
| timstof_class1 8 14 800:2500 1:4 20 ppm 0.01 0.0 timsTOF CID high_res 3 Oxidation (M) | ||
| timstof_class2 8 30 800:5000 1:5 20 ppm 0.01 0.0 timsTOF CID high_res 5 Oxidation (M) | ||
| astral_class1 8 14 800:2500 2:3 5 ppm 0.01 0.0 Immuno-HCD HCD high_res 3 Oxidation (M) | ||
| astral_class2 8 30 800:5000 2:5 5 ppm 0.01 0.0 Immuno-HCD HCD high_res 5 Oxidation (M) | ||
| xl_class1 8 14 800:2500 2:3 5 ppm 0.50025 0.4 CIDch2 CID low_res 3 Oxidation (M) | ||
| xl_class2 8 30 800:5000 2:5 5 ppm 0.50025 0.4 CIDch2 CID low_res 5 Oxidation (M) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.