Conversation
AlexVCaron
left a comment
AlexVCaron
left a comment
There was a problem hiding this comment.
A great start for your first module, some minor things to adjust and it'll be perfect !
| --- | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/meta-schema.json | ||
| name: "tensor_ratio" | ||
| description: Split the tensor image and compute the ratio of Dxx to Dyy and Dxx to Dzz for ALPS. |
There was a problem hiding this comment.
Specify to which convention the tensor image must abide to (I assume it's FSL). Something like :
The tensor elements must be ordered following convention, that is : Dxx, Dxy, Dxz, Dyy, Dyz, Dzz.
| tuple val(meta), path("*_Dxx_to_Dyy.nii.gz") , emit: tensor_x_to_y | ||
| tuple val(meta), path("*_Dxx_to_Dzz.nii.gz") , emit: tensor_x_to_z |
There was a problem hiding this comment.
I feel the names ratio_x_on_y or eval_x_on_y (same for x on z) would convey a better meaning. If you agree, please adjust, here and in the meta.
There was a problem hiding this comment.
This snapshot will have to be updated
There was a problem hiding this comment.
Remove the TODO comments in this file.
There was a problem hiding this comment.
Do you think the ratio of y on z could be interesting for someone ? If so, please add it to the module.
2 participants
Type of improvement
If submitting a new module or fixing a bug, please use the appropriate template.
Describe your improvement
Add a module to create tensor ratio map for DTI-ALPS computation.
Describe how to test your improvement
to be tested with a tensor image (DTI or FW-DTI) as the input
Checklist before requesting a review