Skip to content

some EMS may report consumption as positive, and generation as negative#442

Open
ccutrer wants to merge 1 commit intongardiner:mainfrom
ccutrer:negative_generation
Open

some EMS may report consumption as positive, and generation as negative#442
ccutrer wants to merge 1 commit intongardiner:mainfrom
ccutrer:negative_generation

Conversation

@ccutrer
Copy link
Copy Markdown

@ccutrer ccutrer commented Mar 30, 2022

so automatically negate a negative generation value

so automatically negate a negative generation value
@ngardiner
Copy link
Copy Markdown
Owner

Thanks for this. Which EMS module were you seeing the negative values from? Just trying to evaluate whether or not this should be adjusted at the edge or here in the core, as it's possible some EMS modules may need to influence consumption by returning negative generation values (I'm not sure that's the case but vaguely remember something like this somewhere in the code), if this is done by any of the EMS modules then the change in this PR would require those modules to detect negative values and report them as consumption instead.

In fact, I think we had the code you've written in the past and then removed it for this reason but I'm not 100% sure, I'll need to do some research.

@ccutrer
Copy link
Copy Markdown
Author

ccutrer commented Jul 25, 2022

My root EMS is IoTaWatt. TWCManager sees it via OpenHAB (because I have multiple sub panels, and no single CT measuring complete house consumption, so OpenHAB dynamically sums the total of each sub panel to get its total usage number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants