Conversation
|
Hi @MikeBishop, I think this would be a good candidate for merging prior to Feb 1 to reduce potential API costs, but I see that the PR targets the mqtt_data branch, is that intentional & do you think it's a good time to merge? |
|
That was deliberate, because it builds on things contained in that branch but I wanted this to be reviewable separately. I think both are ready to merge; we can retarget this to main once #571 is in. |
|
I would be fine to merge this and have a follow-up, but I have noticed my car not stopping sometimes when it really ought to. I have a suspicion the bug is in this PR, but I haven't found it yet -- because if I restart it on the debugger, it stops correctly. |
|
Merging for the command savings; if the bug around not stopping persists, we can track that as a separate issue. |
This targets the two useless commands I identified in #591; if others are noted, I can add them. It's based on #571, since it needs some of the additional state that was picked up there; I'll retarget to main once that's merged.
stopAskingToStartChargingis set on the last-connected vehicle if that vehicle last reported an estimated time-to-completion of less than five minutes.It now also eliminates an additional useless command I discovered from my tesla-proxy logs: