-
Notifications
You must be signed in to change notification settings - Fork 121
Update naas docs to call out expectations on network attachments #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
21fca90 to
3e27e05
Compare
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
3e27e05 to
9934f52
Compare
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
9934f52 to
7cde241
Compare
ADubhlaoich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM from a docs style perspective
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
08b2a17 to
6695bfc
Compare
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
content/nginxaas-google/getting-started/create-deployment/deploy-console.md
Outdated
Show resolved
Hide resolved
amudukutore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puneetsarna - I'm okay committing these changes as is but would prefer to incorporate the minor suggestions on calling out some of these changes more explicitly (it's up to you). I'm approving this either way.
6695bfc to
74db009
Compare
We have cases where users will have network attachments with a list of projects allowed on it. We are making changes to the service to handle this better and float the error to the user. This change calls out what the user sees and should do in a situation where flow they have project allowlists on the network attachment.
74db009 to
968491a
Compare
We have cases where users will have network
attachments with a list of projects allowed on it. We are making changes to the service to handle
this better and float the error to the user.
This change calls out what the user sees and
should do in a situation where flow they have
project allowlists on the network attachment.
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩