-
Notifications
You must be signed in to change notification settings - Fork 96
fix: Added instruction to install NIM 2.19.0 #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
I have hereby read the F5 CLA and agree to its terms |
I have some concerns about the number of call outs being added. We should try to keep the number of callouts at a minimum. |
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
How long do we need to continue documenting 2.18 and earlier? The doc covers deployments for <= 2.18, 2.19.x, and 2.20, and it's starting to get a little convoluted. |
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: Added instruction to install NIM 2.19.0 * fix: minor fixes * fix: call out about the new helm chart versioning * fix: added openshift details in nim k8s docs * fix: minor changes * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * fix: Update deploy-using-helm.md * fix: Update deploy-using-helm.md * fix: combined call-out of renaming and versioning * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * Update content/nim/deploy/kubernetes/deploy-using-helm.md Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com> * fix: minor yaml fixes * fix: minor changes --------- Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
No description provided.