-
Notifications
You must be signed in to change notification settings - Fork 95
NGINXaaS: Add display name to metrics catalog #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f8944a7
to
844e8a9
Compare
I have hereby read the F5 CLA and agree to its terms |
d805b6b
to
7070c21
Compare
7070c21
to
e821136
Compare
@@ -2,14 +2,14 @@ | |||
title: Migrate from Custom metrics to Platform metrics | |||
weight: 1000 | |||
toc: true | |||
url: /nginxaas/azure/getting-started/migrate-to-platform-metrics/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a redirect for this so any old links to getting-started
still work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you decide you do, please request it in the docs channel in slack for the docops engineers to create it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future: I spot checked a few and they look right, but copilot makes me nervous. These are all supposed to match https://github.com/nginxinc/nalb-shared/blob/main/nginx/native-metrics/spec.json, right? Maybe copilot could write a script to generate these tables from that file, then we'd have something deterministic. Maybe the next time we need to change these tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes they are all supposed to match https://github.com/nginxinc/nalb-shared/blob/main/nginx/native-metrics/spec.json. I asked co-pilot to generate a script and it did a decent job but there are subtle differences in the metrics catalog that makes it hard from being generated from the spec alone. The column 'Roll-up per' is not available in the spec and there are issues with capitalization and ordering. If these need to be fixed manually then it defeats the point of having a script. Perhaps we can drop the 'Roll-up per' column in metrics catalog and change the capitalization and ordering in the spec to match the current format but I don't know if LIFTR/Geneva will like that
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Platform metrics are queried using Display Names in Azure Monitor. Add Display Names to metrics catalog for easy lookup
Solution: Add a new column for Display Name
Testing: local testing
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩