Skip to content

feat: Set up NGF integration to N1 Console #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: Set up NGF integration to N1 Console #902

wants to merge 14 commits into from

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jul 29, 2025

Extensively revised (14 Aug, midday), after extensive discussions with @bjee19 , @sylwang , and @sjberman

Proposed changes

Set up NGF integration into N1 Console.

  • This is similar to https://docs.nginx.com/nginx-one/k8s/add-nic/
    • But since NIC != NGF, I've changed labels / titles as appropriate
    • I've included some of the same steps to set up a data plane key, create a k8s secret, verify a connection, and for troubleshooting (I'm guessing the troubleshooting section, if applicable, will be different)
  • Many of the steps are the same with https://docs.nginx.com/nginx-gateway-fabric/install/helm/
    • I've added an include for one process, I've copy/pasted content with an include for a second process
  • I've included temporary references <!-- in comments --> to the UI and steps that we're using in that process

The primary build page is here: https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf/

I think there's work to be done w/r/t data plane keys. We have a bunch of different ways to create them

  • There's an alert for when a data plane key is within 30 days of expiration
  • This may be best as a separate issue

This might close issue 660.
Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric product/nginx-one Issues related to NGINX One Console labels Jul 29, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/902/

@mjang mjang changed the title DRAFt feat: Set up NGF integration to N1 Console DRAFT feat: Set up NGF integration to N1 Console Jul 29, 2025
@mjang mjang self-assigned this Jul 29, 2025
@mjang mjang changed the title DRAFT feat: Set up NGF integration to N1 Console Working draft: Set up NGF integration to N1 Console Jul 29, 2025
@mjang
Copy link
Contributor Author

mjang commented Jul 29, 2025

cc @sylwang @bjee19

@mjang mjang marked this pull request as ready for review August 6, 2025 14:09
@mjang mjang requested a review from a team as a code owner August 6, 2025 14:09
@mjang mjang changed the title Working draft: Set up NGF integration to N1 Console Set up NGF integration to N1 Console Aug 6, 2025
@mjang mjang changed the title Set up NGF integration to N1 Console feat: Set up NGF integration to N1 Console Aug 6, 2025
@sylwang
Copy link
Contributor

sylwang commented Aug 11, 2025

In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using Manifests, as shown in the Figma design.
https://www.figma.com/design/Y0wCtVRjEa08HNfocSDVUb/GA---NGINX-One-SaaS-Console?node-id=8028-37869&t=HQ1wwsiaEMrrHdw9-0

@mjang mjang requested a review from bjee19 August 13, 2025 20:44
mjang and others added 4 commits August 14, 2025 06:34
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: Alan Dooley <a.dooley@f5.com>
@mjang
Copy link
Contributor Author

mjang commented Aug 14, 2025

In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using Manifests, as shown in the Figma design. https://www.figma.com/design/Y0wCtVRjEa08HNfocSDVUb/GA---NGINX-One-SaaS-Console?node-id=8028-37869&t=HQ1wwsiaEMrrHdw9-0

Now that I've re-reviewed the Figma, I need to come up with a new file, probably add-ngf-manifests.md

Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also be in our best interest to include a link to this doc from the NGF installation docs for users who start there.

@mjang mjang requested a review from a team as a code owner August 14, 2025 19:46
@mjang
Copy link
Contributor Author

mjang commented Aug 14, 2025

In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using Manifests, as shown in the Figma design. https://www.figma.com/design/Y0wCtVRjEa08HNfocSDVUb/GA---NGINX-One-SaaS-Console?node-id=8028-37869&t=HQ1wwsiaEMrrHdw9-0

Now that I've re-reviewed the Figma, I need to come up with a new file, probably add-ngf-manifests.md

see https://github.com/nginx/documentation/pull/902/files#diff-0f3a95e47383180f7981bf1dce261d6cf9df28039ae0c964412656d2a493498e

Build: https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf-manifests/


## Deploy NGINX Gateway Fabric

{{< include "/ngf/installation/deploy-ngf-manifests.md" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The includes don't seem to be rendering for the manifests page. Also, deploying with manifests requires the same prereqs as deploying with helm. Create the namespace, download the secret, create the secret. The difference is supplying CLI flag directly in the manifest:

--nginx-one-dataplane-key-secret=<data_plane_key_secret_name>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've found the problem... keeping this convo unresolved until I check the build in the PR.

Copy link
Contributor Author

@mjang mjang Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjberman Two answers:

@mjang mjang requested a review from sjberman August 15, 2025 14:53
@mjang
Copy link
Contributor Author

mjang commented Aug 15, 2025

In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using Manifests, as shown in the Figma design. https://www.figma.com/design/Y0wCtVRjEa08HNfocSDVUb/GA---NGINX-One-SaaS-Console?node-id=8028-37869&t=HQ1wwsiaEMrrHdw9-0

I might have said earlier -- I've now set up separate files for NGF helm and manifests.

  • Should I also set up separate files for NIC helm and manifests? (I'm going to think about it a bit)

@mjang mjang requested review from sylwang and n-pandey-f5 August 15, 2025 16:29
@mjang mjang requested a review from ADubhlaoich August 15, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric product/nginx-one Issues related to NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants