-
Notifications
You must be signed in to change notification settings - Fork 102
feat: Set up NGF integration to N1 Console #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using |
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: Alan Dooley <a.dooley@f5.com>
Now that I've re-reviewed the Figma, I need to come up with a new file, probably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also be in our best interest to include a link to this doc from the NGF installation docs for users who start there.
Build: https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf-manifests/ |
|
||
## Deploy NGINX Gateway Fabric | ||
|
||
{{< include "/ngf/installation/deploy-ngf-manifests.md" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The includes don't seem to be rendering for the manifests page. Also, deploying with manifests requires the same prereqs as deploying with helm. Create the namespace, download the secret, create the secret. The difference is supplying CLI flag directly in the manifest:
--nginx-one-dataplane-key-secret=<data_plane_key_secret_name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've found the problem... keeping this convo unresolved until I check the build in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjberman Two answers:
- The build is now rendering for the manifests page. https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf-manifests/#deploy-nginx-gateway-fabric
- The only reference I see to the
--nginx-one-dataplane-key-secret" is in https://docs.nginx.com/nginx-gateway-fabric/reference/cli-help/. And that refers to the
gateway controller [flags]` command, which we have not referenced in this page- I think I need to add two references from this page:
- https://docs.nginx.com/nginx-gateway-fabric/install/manifests/
- https://docs.nginx.com/nginx-gateway-fabric/reference/cli-help/
- Actually -- only if we describe the use of
gateway controller [flags]
or how the--nginx-one-dataplane-key-secret
is used with kubectl
- Actually -- only if we describe the use of
- In the NGF docs, I see no example where we use
--nginx-one-dataplane-key-secret
.- If we're going to doc the use of the
--nginx-one-dataplane-key-secret
option, we'll need to describe how to usegateway controller
. or if it's useable with a command likekubectl
(as referenced from this section), then I need a usable example.
- If we're going to doc the use of the
- I think I need to add two references from this page:
I might have said earlier -- I've now set up separate files for NGF helm and manifests.
|
Extensively revised (14 Aug, midday), after extensive discussions with @bjee19 , @sylwang , and @sjberman
Proposed changes
Set up NGF integration into N1 Console.
<!-- in comments -->
to the UI and steps that we're using in that processThe primary build page is here: https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf/
I think there's work to be done w/r/t data plane keys. We have a bunch of different ways to create them
This might close issue 660.
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩