-
Notifications
You must be signed in to change notification settings - Fork 2k
update crd descriptions #8038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update crd descriptions #8038
Conversation
Package Report
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx, 1.27.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-module-njs, 1.27.5+0.8.10-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-module-otel, 1.27.5+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 3.0.3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx, 1.27.5-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-module-njs, 1.27.5+0.8.10-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-module-otel, 1.27.5+0.1.2-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 3.0.3~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 3.0.3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus, 34-2~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-njs, 34+0.8.9-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-otel, 34+0.1.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-fips-check, 34+0.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 3.0.3~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-attack-signatures, 2025.07.17-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-threat-campaigns, 2025.07.16-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 2.42.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-module-plus, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-plugin, 6.16.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 2.42.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-appprotectdos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-dos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-attack-signatures, 2025.07.17-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-threat-campaigns, 2025.07.16-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-plus-module-appprotectdos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, app-protect-dos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12, nginx-agent, 2.42.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx, 1.27.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-module-njs, 1.27.5.0.8.10-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-module-otel, 1.27.5.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-agent, 3.0.3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx, 1.27.5-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-module-njs, 1.27.5.0.8.10-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-module-otel, 1.27.5.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-agent, 3.0.3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-agent, 3.0.3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus, 34-r2, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus-module-njs, 34.0.8.9-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus-module-otel, 34.0.1.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-plus-module-fips-check, 34.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine, nginx-agent, 3.0.3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-agent, 3.0.3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus, 34-r2, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-agent, 3.0.3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-agent, 2.42.0, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-appprotect, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, app-protect, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, app-protect-attack-signatures, 2025.07.17-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, app-protect-threat-campaigns, 2025.07.16-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-agent, 2.42.0, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, nginx-plus-module-appprotect, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, app-protect-module-plus, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-alpine-fips, app-protect-plugin, 6.16.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx, 1.27.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-module-njs, 1.27.5+0.9.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-module-otel, 1.27.5+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 3.0.3-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx, 1.27.5-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-module-njs, 1.27.5+0.9.0-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-module-otel, 1.27.5+0.1.2-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 3.0.3-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 3.0.3-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus, 34-2.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 3.0.3-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-attack-signatures, 2025.07.17-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-threat-campaigns, 2025.07.16-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-module-plus, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-plugin, 6.16.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus, 34-2.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-njs, 34+0.8.9-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-otel, 34+0.1.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-fips-check, 34+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-appprotect, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, app-protect, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, app-protect-attack-signatures, 2025.07.17-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, app-protect-threat-campaigns, 2025.07.16-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus, 34-2.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-njs, 34+0.8.9-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-otel, 34+0.1.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-fips-check, 34+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, nginx-plus-module-appprotect, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, app-protect-module-plus, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi8, app-protect-plugin, 6.16.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-appprotectdos, 34+4.6.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-dos, 34+4.6.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-plus-module-appprotectdos, 34+4.6.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-attack-signatures, 2025.07.17-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-threat-campaigns, 2025.07.16-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-b9d91d829c9a86f0d704ea130b317c12-ubi, app-protect-dos, 34+4.6.1-1.el9.ngx, x86_64 |
I have hereby read the F5 CLA and agree to its terms |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8038 +/- ##
==========================================
+ Coverage 52.96% 53.00% +0.03%
==========================================
Files 90 90
Lines 21729 21749 +20
==========================================
+ Hits 11508 11527 +19
- Misses 9744 9745 +1
Partials 477 477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have hereby read the F5 CLA and agree to its terms |
Signed-off-by: mohamad_al <m.aldawamneh@f5.com>
Secret string `json:"secret"` | ||
} | ||
|
||
// IngressMTLS defines an Ingress MTLS policy. | ||
// The IngressMTLS policy configures client certificate verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting The
in-front of the Type comment will affect linting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thiis still needs addressing in various places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly all of the "the" is in the documentation and i have ran the "make lint" script and it ran just fine .
deploy/crds.yaml
Outdated
@@ -135,24 +135,37 @@ spec: | |||
metadata: | |||
type: object | |||
spec: | |||
description: GlobalConfigurationSpec is the spec of the GlobalConfiguration | |||
resource. | |||
description: spec field of the GlobalConfiguration resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the description of this should be more similar to what we have in docs instead X field of Y.
These descriptions are to tell the reader what exactly this does, rather than what it is.
deploy/crds.yaml
Outdated
PolicySpec is the spec of the Policy resource. | ||
The spec includes multiple fields, where each field represents a different policy. | ||
Only one policy (field) is allowed. | ||
description: spec field of the Policy resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older description was better, this is too generic
description: spec field of the Policy resource | |
description: |- | |
PolicySpec is the spec of the Policy resource. | |
The spec includes multiple fields, where each field represents a different policy. | |
Only one policy (field) is allowed. |
properties: | ||
accessControl: | ||
description: AccessControl defines an access policy based on the source | ||
IP of a request. | ||
description: The access control policy based on the client IP address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
description: The access control policy based on the client IP address. | |
description: AccessControl defines an access policy based on the source | |
IP of a request. |
Spec GlobalConfigurationSpec `json:"spec"` | ||
} | ||
|
||
// GlobalConfigurationSpec is the spec of the GlobalConfiguration resource. | ||
type GlobalConfigurationSpec struct { | ||
// Listeners field of the GlobalConfigurationSpec resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
@@ -423,6 +579,7 @@ type Listener struct { | |||
type GlobalConfigurationList struct { | |||
metav1.TypeMeta `json:",inline"` | |||
metav1.ListMeta `json:"metadata"` | |||
// Items field of the GlobalConfigurationList resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
pkg/apis/configuration/v1/types.go
Outdated
@@ -441,23 +598,34 @@ type GlobalConfigurationList struct { | |||
type TransportServer struct { | |||
metav1.TypeMeta `json:",inline"` | |||
metav1.ObjectMeta `json:"metadata,omitempty"` | |||
|
|||
Spec TransportServerSpec `json:"spec"` | |||
// spec field of the TransportServer resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
pkg/apis/configuration/v1/types.go
Outdated
BackupPort *uint16 `json:"backupPort"` | ||
// The name of the upstream. Must be a valid DNS label as defined in RFC 1035. For example, hello and upstream-123 are valid. The name must be unique among all upstreams of the resource. | ||
Name string `json:"name"` | ||
// The name of a service. The service must belong to the same namespace as the resource. If the service doesn’t exist, NGINX will assume the service has zero endpoints and return a 502 response for requests for this upstream. For NGINX Plus only, services of type ExternalName are also supported (check the prerequisites ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does check the prerequisites
mean in this context?
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.