ACME: check supported challenges only for pending authorizations. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the ACME authorization handling to only check for supported challenges on pending authorizations, allowing valid authorizations without advertised challenges. This accommodates certificate authorities that perform validation through alternative means rather than implementing the standard ACMEv2 identifier validation.
Key Changes
- Challenge support checks are now performed only for pending authorizations
- Valid authorizations can proceed without requiring advertised challenges
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A valid authorization object does not have to advertise any challenges.
I expect that to happen with certificate authorities that do not implement the identifier validation part of ACMEv2 and perform the validation by other means.