-
Notifications
You must be signed in to change notification settings - Fork 132
Add CEL validation tests for ObservabilityPolicy
CRD
#3735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
- Coverage 86.89% 86.86% -0.04%
==========================================
Files 128 128
Lines 16187 16187
Branches 62 62
==========================================
- Hits 14066 14061 -5
- Misses 1949 1953 +4
- Partials 172 173 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like a lot of these separate test functions could just be combined into one, to reduce duplication. They are ultimately formatted and testing very similar things. For example, 3 different test functions that are testing the TargetRef field. Could be one large list of structs in a single test IMO.
Proposed changes
This change adds test for the CEL validation for the
ObservabilityPolicy
CRCloses #3670
Checklist
Before creating a PR, run through this checklist and mark each as complete.