-
Notifications
You must be signed in to change notification settings - Fork 131
Add readiness probes to deployments in functional tests #3740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
==========================================
+ Coverage 86.86% 86.88% +0.01%
==========================================
Files 128 128
Lines 16187 16187
Branches 62 62
==========================================
+ Hits 14061 14064 +3
+ Misses 1953 1950 -3
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For testing can you run the functional tests locally a few times (i know the pipeline runs it 4 times) to make sure there aren't any flakey situations? Also can you verify the readiness probes are applied in the deployments when the tests are running? |
@sarthyparty Yea that looks like its probably not an issue with the example apps not being ready in time (something that wouldn't get fixed with the readiness probes) so the other tests passing consistently is good. Were you also able to verify the readiness probes in the deployment yaml as the apps were rolling out? |
I saw the readiness probe on the pod and deployment when I described them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this updates the probes in the NFRs too, but i think thats fine/better. nice
e9e1178
to
7281bb0
Compare
7281bb0
to
a5de465
Compare
Proposed changes
Problem: Functional tests failed inconsistently, due to deployments and pods not be ready.
Solution: Added readiness probes to all deployments.
Testing: N/A
Closes #1866
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.