Skip to content

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Problem: After the secure build workflow changes, on main or production runs the build binary job was running on a different runner type from the helm tests job meaning the cache doesn't work correctly between these stages.

Additionally, the nightly run attempts to log in to the NGINX image registry using the actor of the pipeline. This has been failing as the actor of the scheduled builds no longer works here.

Solution: Use artifact upload and download instead of cache for the binary so it persists across runner types, and edit the schedule line with a comment so that I appear as the actor for the nightly runs instead

Closes #4032

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added the bug Something isn't working label Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (2d2dfa8) to head (53af29c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4033      +/-   ##
==========================================
- Coverage   86.71%   86.69%   -0.02%     
==========================================
  Files         128      128              
  Lines       16758    16758              
  Branches       62       62              
==========================================
- Hits        14531    14529       -2     
- Misses       2043     2044       +1     
- Partials      184      185       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 marked this pull request as ready for review October 7, 2025 09:34
@ciarams87 ciarams87 requested a review from a team as a code owner October 7, 2025 09:34
@ciarams87 ciarams87 force-pushed the fix/helm-tests-and-nightly branch from 051f1cc to 010c623 Compare October 9, 2025 15:49
@ciarams87 ciarams87 enabled auto-merge (squash) October 9, 2025 15:50
@ciarams87 ciarams87 force-pushed the fix/helm-tests-and-nightly branch from 010c623 to 0ec0e0e Compare October 9, 2025 20:26
@ciarams87 ciarams87 force-pushed the fix/helm-tests-and-nightly branch from 0ec0e0e to 53af29c Compare October 9, 2025 21:00
@ciarams87 ciarams87 merged commit e61e38a into main Oct 9, 2025
59 of 61 checks passed
@ciarams87 ciarams87 deleted the fix/helm-tests-and-nightly branch October 9, 2025 21:29
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Helm tests and publish are failing in main
4 participants