Use download artifact instead #4033
Merged
+14
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: After the secure build workflow changes, on main or production runs the build binary job was running on a different runner type from the helm tests job meaning the cache doesn't work correctly between these stages.
Additionally, the nightly run attempts to log in to the NGINX image registry using the actor of the pipeline. This has been failing as the actor of the scheduled builds no longer works here.
Solution: Use artifact upload and download instead of cache for the binary so it persists across runner types, and edit the schedule line with a comment so that I appear as the actor for the nightly runs instead
Closes #4032
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.