Skip to content

Conversation

tataruty
Copy link
Contributor

@tataruty tataruty commented Oct 7, 2025

Proposed changes

Problem:
As an NGF user,
I want clear feedback when I've specified a field that is unsupported by NGF,
So that I understand why certain features aren't working.
Routes should still be considered valid and configured, so we don't break existing users

Solution:
For all fields in various resources (Gateway, HTTPRoute, GRPCRoute, etc) that NGF does not yet support, add validation and error conditions if they are specified
Routes should still be considered valid and configured, so we don't break existing users

Testing: Unit tests
deploy:
image
image

Please focus on (optional):
for documentation:
nginx/documentation#1268

Closes #3784

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@tataruty tataruty requested a review from a team as a code owner October 7, 2025 13:16
@github-actions github-actions bot added the enhancement New feature or request label Oct 7, 2025
@tataruty tataruty requested a review from ciarams87 October 7, 2025 13:16
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 85.10638% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (a4ff583) to head (631f83a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/state/conditions/conditions.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
- Coverage   86.74%   86.73%   -0.01%     
==========================================
  Files         128      128              
  Lines       16664    16758      +94     
  Branches       62       62              
==========================================
+ Hits        14455    14535      +80     
- Misses       2026     2039      +13     
- Partials      183      184       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Oct 7, 2025
@tataruty tataruty force-pushed the enhancement/unsupported_fields_validation branch from 798c498 to ac3e22e Compare October 8, 2025 09:35
@tataruty tataruty force-pushed the enhancement/unsupported_fields_validation branch from 16728da to e9719f7 Compare October 8, 2025 12:20
@tataruty tataruty force-pushed the enhancement/unsupported_fields_validation branch from e9719f7 to 43e0c77 Compare October 9, 2025 10:44
@tataruty tataruty force-pushed the enhancement/unsupported_fields_validation branch from 43e0c77 to 89b9190 Compare October 9, 2025 11:45
@tataruty tataruty merged commit 1bfa2e9 into main Oct 9, 2025
183 of 219 checks passed
@tataruty tataruty deleted the enhancement/unsupported_fields_validation branch October 9, 2025 16:56
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Return validation error when unsupported fields are set
3 participants