Skip to content

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 81.91489% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (d4e4472) to head (7771846).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ernal/controller/nginx/config/validation/common.go 75.67% 7 Missing and 2 partials ⚠️
...controller/nginx/config/validation/http_filters.go 0.00% 4 Missing ⚠️
internal/controller/state/graph/httproute.go 84.61% 2 Missing ⚠️
internal/controller/nginx/config/servers.go 97.29% 1 Missing ⚠️
internal/controller/state/validation/validator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4047      +/-   ##
==========================================
- Coverage   86.77%   86.73%   -0.04%     
==========================================
  Files         128      128              
  Lines       16607    16664      +57     
  Branches       62       62              
==========================================
+ Hits        14411    14454      +43     
- Misses       2012     2026      +14     
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 changed the title Temp/fix pr build DO NOT MERGE: Temp/fix pr build Oct 9, 2025
Problem: As regex path matching is missing support for NGF.

Solution: Add support for regex path matching, only allow a full path rewrite/redirect after the regex path match.

Testing: Add additional unit test case for regex path match.
@ciarams87 ciarams87 closed this Oct 9, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 9, 2025
@ciarams87 ciarams87 deleted the temp/fix-PR-build branch October 9, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants