Skip to content

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Oct 9, 2025

Proposed changes

Problem: Uploading of the SBOMs and checksums to Azure is failing in the release pipeline. The SBOM and checksum are still being uploaded to the Releases tab as release assets.

Solution: Remove the upload to Azure step and work with the security team for the best path forward

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3971

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner October 9, 2025 09:56
@github-actions github-actions bot added the bug Something isn't working label Oct 9, 2025
@ciarams87 ciarams87 force-pushed the fix/remove-azure-upload branch from f252015 to d720b9a Compare October 9, 2025 09:57
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (e61e38a) to head (49a68a3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4049      +/-   ##
==========================================
- Coverage   86.72%   86.69%   -0.03%     
==========================================
  Files         128      128              
  Lines       16758    16758              
  Branches       62       62              
==========================================
- Hits        14534    14529       -5     
- Misses       2040     2044       +4     
- Partials      184      185       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the fix/remove-azure-upload branch from d720b9a to e91a6c4 Compare October 9, 2025 20:26
@ciarams87 ciarams87 force-pushed the fix/remove-azure-upload branch from e91a6c4 to 49a68a3 Compare October 9, 2025 21:31
@ciarams87 ciarams87 enabled auto-merge (squash) October 9, 2025 21:31
@ciarams87 ciarams87 merged commit 690d123 into main Oct 9, 2025
60 of 61 checks passed
@ciarams87 ciarams87 deleted the fix/remove-azure-upload branch October 9, 2025 22:00
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

goreleaser failed to complete during release due to Azure token expiry
3 participants