-
Notifications
You must be signed in to change notification settings - Fork 356
Fix building with PHP 8.5 #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
also I disabled following tests
|
Can we limit the #ifdeferry to the |
Yes, it could be cleaner to limit ifdef to the function only but there's no zend structure anymore so yoou need to change calling code anyway.
Another option could be deprecation of So ATM it's not clear which way is preferable, moreover |
It was just a thought. I will probably squeeze this into 1.35.0 (which is likely to be the |
Seeing as I don't have permissions to update this branch, can you rebase
Thanks! |
Actually make the commit message
(Note: no <> on the closes link as GitHub still doesn't recognise that) |
doing |
Closes: nginx#1646 Link: <php/php-src@f4e2e91> Signed-off-by: Andy Postnikov <apostnikov@gmail.com>
ready EDIT: somehow I can grant permission allowing maintainers to allow edits( |
Thanks! |
Proposed changes
The
diable_classes
is deprecated since PHP 8.5, see php/php-src@f4e2e91Making this build conditional also require to change tests
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.md
and/orCHANGELOG.md
).