Skip to content

Fixing warnings #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnrees wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing warnings #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0699108
updated dependencies
johnrees Nov 2, 2017
9d9b355
added alt tags to images
johnrees Nov 2, 2017
fea02b2
added crossorigin to img tags
johnrees Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
"version": "3.0.1",
"description": "Boilerplate for building virtual reality experiences with A-Frame and React.",
"dependencies": {
"aframe": "^0.5.0",
"aframe": "^0.7.1",
"aframe-animation-component": "^3.2.5",
"aframe-particle-system-component": "^1.0.8",
"aframe-react": "^4.0.x",
"aframe-particle-system-component": "^1.0.10",
"aframe-react": "^4.3.0",
"babel-polyfill": "^6.3.14",
"react": "^15.4.1",
"react-dom": "^15.4.1",
"react-scripts": "0.9.5"
"react-scripts": "^1.0.16"
},
"scripts": {
"start": "react-scripts start",
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ class App extends React.Component {
return (
<Scene>
<a-assets>
<img id="groundTexture" src="https://cdn.aframe.io/a-painter/images/floor.jpg"/>
<img id="skyTexture" src="https://cdn.aframe.io/a-painter/images/sky.jpg"/>
<img crossOrigin="anonymous" alt="ground texture" id="groundTexture" src="https://cdn.aframe.io/a-painter/images/floor.jpg"/>
<img crossOrigin="anonymous" alt="sky texture" id="skyTexture" src="https://cdn.aframe.io/a-painter/images/sky.jpg"/>
</a-assets>

<Entity primitive="a-plane" src="#groundTexture" rotation="-90 0 0" height="100" width="100"/>
Expand Down
Loading