Fixed WriteSingleCoil function#6
Open
VitaliiShevchenko wants to merge 5 commits intongorke:masterfrom
Open
Conversation
Changed name "slave" on the "client" relatable Modbus specification
Owner
|
Hi, sorry for taking so long to look at your PR. As far as I know, the terminology for Modbus RTU is master/slave, so unless you show otherwise, I think it would be wrong to merge the PR. Additionally, renaming the class would require existing users to change their code, which I would rather not do. Good catch on the bug! 👍 I would merge this if it were only a change to the code, and not renaming slave / master to client / server. If you disagree with this, please tell me why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug relatable with disability to write high level of single coil