Skip to content

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR updates the store walkthrough example, to match the steps with the code.
It also updates the example to be able to run it via StackBlitz.

Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit fd29f1b
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/68d300b377392900082c7a3a

Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit fd29f1b
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/68d300b375f2c70008abd958
😎 Deploy Preview https://deploy-preview-4955--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Component({
selector: 'app-book-collection',
template: `
@for(book of books; track book) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All templates are inline to run the example in vite/stackblitz.
This also means that no css is imported.

`,
})
export class BookCollection {
@Input()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the example doesn't run on stackblitz with the signal input and new output API.

@timdeschryver timdeschryver added the Needs Cleanup Review changes needed label Sep 11, 2025
@timdeschryver timdeschryver force-pushed the update-walkthrough branch 2 times, most recently from f2f0fa2 to 4b41db8 Compare September 12, 2025 16:19
@timdeschryver timdeschryver removed the Needs Cleanup Review changes needed label Sep 12, 2025
@timdeschryver timdeschryver force-pushed the update-walkthrough branch 2 times, most recently from 82078cb to df8a9e9 Compare September 19, 2025 17:18
Copy link
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t review every line in detail, but nothing stood out as problematic.

@markostanimirovic markostanimirovic merged commit 38db088 into main Sep 23, 2025
14 checks passed
@markostanimirovic markostanimirovic deleted the update-walkthrough branch September 23, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants