Skip to content

Support for Pico offset limits #448 #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
preamp-org wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support for Pico offset limits #448 #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
088347b
Add function "GetChannelOffset"
preamp-org Jan 31, 2026
77feb88
Delete PicoOscilloscope.h
preamp-org Jan 31, 2026
6eb45a8
Delete PicoOscilloscope.cpp
preamp-org Jan 31, 2026
c351c1a
Add function "GetChannelOffset"
preamp-org Jan 31, 2026
30ca42a
Support for Pico offset limits #448
preamp-org Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scopehal/PicoOscilloscope.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,18 @@ void PicoOscilloscope::SetChannelBandwidthLimit(size_t i, unsigned int limit_mhz
m_transport->SendCommand(GetOscilloscopeChannel(i)->GetHwname() + ":BWLIM " + to_string(limit_mhz));
}

void PicoOscilloscope::SetChannelOffset(size_t i, size_t /*stream*/, float offset)
{
float maxOff = abs(stof(m_transport->SendCommandQueuedWithReply(GetOscilloscopeChannel(i)->GetHwname() + ":OFLIM?")));
float minOff = -maxOff;

offset = min(maxOff, offset);
offset = max(minOff, offset);
//LogDebug("SetChannelWaveform: %f\t %f\t\n", maxOff, offset);

RemoteBridgeOscilloscope::SetChannelOffset(i, 0, offset);
}

OscilloscopeChannel* PicoOscilloscope::GetExternalTrigger()
{
//FIXME
Expand Down
1 change: 1 addition & 0 deletions scopehal/PicoOscilloscope.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class PicoOscilloscope : public virtual RemoteBridgeOscilloscope
virtual void SetChannelBandwidthLimit(size_t i, unsigned int limit_mhz) override;
virtual OscilloscopeChannel* GetExternalTrigger() override;
virtual bool CanEnableChannel(size_t i) override;
virtual void SetChannelOffset(size_t i, size_t stream, float offset) override;

//Triggering
virtual void BackgroundProcessing() override;
Expand Down