This repository was archived by the owner on Apr 27, 2025. It is now read-only.
deps: add logic to moksha-wallet dependencies#247
Draft
EthnTuttle wants to merge 6 commits intongutech21:masterfrom
Draft
deps: add logic to moksha-wallet dependencies#247EthnTuttle wants to merge 6 commits intongutech21:masterfrom
EthnTuttle wants to merge 6 commits intongutech21:masterfrom
Conversation
Owner
|
LGTM We need an additional github Action for compiling to esp and a just task like build-esp that gets called in final-check |
Author
I'm going to hold off on that.
I plan to keep this branch open on my fork for development and once I get some more progress on a PoC for the embedded implementation, I'll make a task to work toward compiling and such directly within the moksha repo. My PoC goal is a naive impl of Thank you for helping sort out the dependency issues. (ps. happy to close this PR while I work, as I anticipate this sitting open for a while) |
While attempting to compile for esp32 boards using esp-rs crates, moksha-wallet couldn't be depended on because of various compile errors. When compiling for esp, you are not targeting wasm. Irconically, the wasm dependencies mostly compiled for esp. This commit adds logic so espcash can depend directly on moksha to more easily implement an ecash clinet for embedded devices.
8e3d10c to
9aed9d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to compile for esp32 boards using esp-rs crates, moksha-wallet couldn't be depended on because of various compile errors. When compiling for esp, you are not targeting wasm. Irconically, the wasm dependencies mostly compiled for esp. This commit adds logic so espcash can depend directly on moksha to more easily implement an ecash clinet for embedded devices.