fix: prevent integer overflow and negative distance in position calculation #97
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dto valid range to prevent negative/invalid values from normal distributionCloses #96
Root Cause
When generating paired-end reads, the distance
dis calculated from a normal distribution. With extreme values (e.g., -10 sigma),dcan become negative, causing:(l - d + 1)to overflowChanges
Both occurrences in
dwgsim_core()are fixed:Test plan
make test-integration)🤖 Generated with Claude Code