Pull in 26.0 finals of nifgen driver grpc-device metadata#1254
Pull in 26.0 finals of nifgen driver grpc-device metadata#1254WengLoon-NI wants to merge 2 commits intoni:mainfrom
Conversation
WengLoon-NI
requested review from
astarche,
maxxboehme and
reckenro
as code owners
| import "session.proto"; | ||
|
|
||
| service NiFgen { | ||
| rpc AbortGeneration(AbortGenerationRequest) returns (AbortGenerationResponse); |
There was a problem hiding this comment.
I'm trying to figure out why the hapigen produced proto file is messing with the order of things. I'll circle back on this when I figure that out with guidance.
There was a problem hiding this comment.
Figured out the issue on the hapigen side.
Working on a fix in this AzDo PR
And reflecting updated NI Fake service as validation in this GitHub PR
But even after those go in, it won't fix the sorting in this older FGEN proto generated by hapigen.
So, for this PR, I'm okay with you getting past this issue by:
- Copying
generated/nifgen/nifgen.prototosource/codegen/metadata/nifgen/nifgen.proto.
The metadata is the same generating the proto, and the content is the same in resulting protos, it's just a sorting issue so I'm fine with this mitigation for now. For the next FGEN release, the proto coming from hapigen should be sorted again.
There was a problem hiding this comment.
@WengLoon-NI , you're going to have to do this to get the build passing:
- Replace
source/codegen/metadata/nifgen/nifgen.protowith a copy ofgenerated/nifgen/nifgen.proto
There was a problem hiding this comment.
Done replace the nifgen.proto in source/codegen/metadata/nifgen/ with a copy of generated/nifgen. thanks for the point out
reckenro
added
the
binary-breaking
reckenro
left a comment
reckenro
left a comment
There was a problem hiding this comment.
Reset me after you address the comments and I'll take another look through
reckenro
left a comment
reckenro
left a comment
There was a problem hiding this comment.
Looks good, just need to replace metadata proto with generated one to get the build to pass because of hapigen sorting issue.
3 participants
What does this Pull Request accomplish?
Pulls in the 26.0 final grpc-device metadata for the nifgen drivers.
Why should this Pull Request be merged?
The nifgen.proto file was outdated, leading to a mismatch in message extraction between the gRPC client and server.
What testing has been done?
Breaking Changes / Removals
Impact: Any client code referencing the old edge field must be updated.
Impact: Clients relying on these RPCs must remove or refactor calls, as they are no longer available.